Fix string representation of extended search filters #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want to render search filters similar to e.g., Wireshark. In order to calculate a string representation of extended search filter we need to output their values in a order which is different from other fields. This patch fixes this directly, but the bigger issue is probably that `DecodedAttributeValue` is a too generic unit and we should have lower-level types for constructs like extended search filters which know how to render themselves correctly. Closes #23.
rsmmr
approved these changes
Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to render search filters similar to e.g., Wireshark. In order to calculate a string representation of extended search filter we need to output their values in a order which is different from other fields.
This patch fixes this directly, but the bigger issue is probably that
DecodedAttributeValueis a too generic unit and we should have lower-level types for constructs like extended search filters which know how to render themselves correctly.Closes #23.